Percona-QA / percona-qa

Percona QA is a suite of scripts and utilities that assists in building, continuous integration, automated testing & bug reporting for Percona Server, Percona XtraDB Cluster, Percona XtraBackup, Percona Server for MongoDB, as well as other flavors of MySQL (Oracle, Facebook MyQSL, WebScaleSQL, MariaDB) etc.
GNU General Public License v2.0
67 stars 44 forks source link

Fix get_download_link.sh #351

Closed ghost closed 3 years ago

ghost commented 3 years ago

This PR fixes most of the broken tests and failures to provide a link in the get_download_link.sh script, expands the test coverage to source tarballs and to non-default distribution variants, and addresses an issue where requesting a MySQL 5.5 or 5.6 link would return an 8.0 link instead, by making sure it fails instead of providing the wrong link. Less-often used paths of the script probably remain broken, but the main "happy paths" under test should at least be working.

A known issue left is that, while the test for PostgreSQL passes, and a link is provided when no version is specified, due to the website used as source of truth being somewhat outdated, the latest version it provides is 9.3. In any case, I'm not sure how feasible it would be to fix this to bring it up-to-date to the current version, since Postgres itself stopped providing raw binary tarballs after 12.4, switching to source distribution and packaged binaries only.