search

PerditionC / VBAChromeDevProtocol

VBA (Excel) based wrapper for Chrome Developer Protocol (CDP) - sorta a VBA version of Puppeteer/Selenium
https://PerditionC.github.io/VBAChromeDevProtocol/
MIT License
60 stars 11 forks source link

Browser paths #3

Closed PerditionC closed 2 years ago

PerditionC commented 2 years ago

Browser paths need to be queried for instead of using hard coded paths. Different installs may and do use different paths.

moaoci commented 2 years ago

Hello, I worked a solution for the hardcoded paths together with an enhancement to easily pass additionnal inline commands to the browser. I also added a switch to force killing of existing browser without a prompt. This is my first contribution to GitHub. If I understand, my next step would be to start with a pull request and submit my code. I know how to test VBA in Excel but not with GitHub.

PerditionC commented 2 years ago

Please export the VBA [class] module(s) from Excel and make a pull request against the corresponding files in the src/ directory. After review and merge I will commit a new version of the Excel files in dist/ directory. Most of my testing is also in Excel, I just export the modules as text to allow diff'ing and usage with git. Thank you.

moaoci commented 2 years ago

When I upload my files, there is a choice for commit directly to main branch or create a new branch... Which one is best ?

PerditionC commented 2 years ago

You can use the main branch. For other projects, a topic branch may be the better option, but for this project that is just unnecessary complication.

moaoci commented 2 years ago

I can't figure out how to undo commit or refresh my fork with the main branch...

PerditionC commented 2 years ago

PR with implementation merged. Thank you.