search

PerditionC / VBAChromeDevProtocol

VBA (Excel) based wrapper for Chrome Developer Protocol (CDP) - sorta a VBA version of Puppeteer/Selenium
https://PerditionC.github.io/VBAChromeDevProtocol/
MIT License
60 stars 11 forks source link

Add files via upload #4

Closed moaoci closed 2 years ago

moaoci commented 2 years ago

ClsCDP and AutomateBrowser were modified to allow these parameters browserType, new killExistingInstance and new additionnalInlineCommands so they reach LaunchBrowser.

browsers.bas was modified to better identify browser .exe path and to prevent from executing an uninstalled link. public function browserStatus was created to identify if browser is «Not installed» «Available» or «Running»

moaoci commented 2 years ago

I expected that differences would be highlighted... Did I not do something important ?

moaoci commented 2 years ago

I found my mistake: I didn't upload the files in the src directory....

PerditionC commented 2 years ago

I will look at the changes tonight and try to get them merged in. Thank you.

moaoci commented 2 years ago

I will close this pull request and restart a new one so I can do it the right way. Remember, it's my first time

PerditionC commented 2 years ago

No problem, I will look out for the new PR.