search

PerditionC / fdkernel

FreeDOS kernel - implements the core MS-DOS/PC-DOS (R) compatible operating system. It is derived from Pat Villani's DOS-C kernel and released under the GPL v2. Please see http://www.freedos.org/ for more details about the FreeDOS (TM) Project. !!! This fork is no longer the primary fork -- Please post PRs and issues to https://github.com/FDOS/kernel !!!
http://dosc.fdos.org/
105 stars 0 forks source link

int2f: Allow 1217h function to return new CDS #21

Closed andrewbird closed 6 years ago

andrewbird commented 6 years ago

When a redirector calls int2f/1217h to get a CDS for creation of a new drive, the cds_flags were being checked for validity. This meant that only the CDS for drives that had previously been initialised could be redirected (without manipulating CDS array directly). This is not the behaviour of other DOS variants which allow the return of the requested CDS regardless.

This patch introduces an unvalidated version of get_cds() and calls it only for the int2f/1217h call, other uses remain as before.

Fixes [#20]

Tested this patch using FDPP platform

andrewbird commented 6 years ago

After discussion with @stsp I force pushed a new much simpler version of the patch here.

andrewbird commented 4 years ago

Hi @PerditionC I see you're working on freedos kernel at the moment. Is there any chance you can review this PR? Nothing has changed since before and the corresponding patch has been working fine in FDPP in the meantime?

Unfortunately I've removed the original repo from where this PR was generated, so I can't reopen the PR myself, but the commit itself should still be accessible to you?

Many Thanks,

Andrew