search

PerezHz / HORIZONS.jl

An interface to NASA-JPL HORIZONS system and other Solar System Dynamics APIs in Julia
Other
17 stars 6 forks source link

Update to julia 1.1-1.2 #14

Closed PerezHz closed 5 years ago

PerezHz commented 5 years ago

This is WIP towards fully supporting julia1.1-1.2

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e98a24d). Click here to learn what that means. The diff coverage is 74.74%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #14   +/-   ##
=========================================
  Coverage          ?   88.88%           
=========================================
  Files             ?        3           
  Lines             ?      252           
  Branches          ?        0           
=========================================
  Hits              ?      224           
  Misses            ?       28           
  Partials          ?        0
Impacted Files Coverage Δ
src/HORIZONS.jl 66.66% <ø> (ø)
src/vec_tbl.jl 98.7% <100%> (ø)
src/smb_spk.jl 73.68% <73.68%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e98a24d...ae3b1c3. Read the comment docs.

PerezHz commented 5 years ago

Tests which are related to FTP downloading from the HORIZONS machine seem to be failing due to a travis issue on Linux; macOS tests don't seem to be affected

PerezHz commented 5 years ago

Merging to master, although tests are not passing due to a travis issue with FTP downloading, which is how HORIZONS asks its users to download generated files (for more info see HORIZONS documentation). In invenia/FTPClient.jl#70 there is an issue similar to what is happening here, although in this case disabling sudo in travis didn't fix the issue. See also this link. As far as I have been able to test HORIZONS.jl in non-travis Linux environments, tests are passing.