search

PerezHz / HORIZONS.jl

An interface to NASA-JPL HORIZONS system and other Solar System Dynamics APIs in Julia
Other
17 stars 6 forks source link

Simplify handling of kwargs; fix MethodError in tests #22

Closed PerezHz closed 4 years ago

PerezHz commented 4 years ago

This PR simplifies handling of keyword arguments in vec_tbl and associated functions, as well as fixing a test: a MethodError should actually be a TypeError. Also, for convenience while performing tests, the "Test for erroneous arguments" test set was moved towards the end of test/runtests.jl.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.07%) to 89.333% when pulling 03a5ca0d4bff5b6d88deab6e00c511a73e334cb1 on jp/fixkwargs into 649d03ec0290c4a067104c999d15dbedf2c2570e on master.

codecov[bot] commented 4 years ago

Codecov Report

Merging #22 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   88.88%   88.88%           
=======================================
  Files           3        3           
  Lines         252      252           
=======================================
  Hits          224      224           
  Misses         28       28
Impacted Files Coverage Δ
src/vec_tbl.jl 98.7% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 649d03e...03a5ca0. Read the comment docs.