PerfectlyNormal / tinymce-rails-imageupload

Image upload plugin for TinyMCE and Rails with the asset pipeline
MIT License
149 stars 153 forks source link

Missing coffescript on gemspec #19

Closed sobrinho closed 11 years ago

sobrinho commented 11 years ago

I'm not using coffescript on my application:

16:24:20 web.1  | WARN: tilt autoloading 'coffee_script' in a non thread-safe way; explicit require 'coffee_script' suggested.
16:24:20 web.1  | Started GET "/assets/tinymce/plugins/uploadimage/editor_plugin.js?3.5.8" for 127.0.0.1 at 2012-12-09 16:24:20 -0200
16:24:20 web.1  | Error compiling asset tinymce/plugins/uploadimage/editor_plugin.js:
16:24:20 web.1  | LoadError: cannot load such file -- coffee_script
16:24:20 web.1  |   (in /Users/sobrinho/Developer/code5/ace/vendor/bundle/ruby/1.9.1/gems/tinymce-rails-imageupload-3.5.6.3/app/assets/javascripts/tinymce/plugins/uploadimage/editor_plugin.js.coffee)
16:24:20 web.1  | Served asset /tinymce/plugins/uploadimage/editor_plugin.js - 500 Internal Server Error

Maybe we should use plain javascript here to avoid an extra dependency (regardless the large adoption of coffescript) or just add it to gemspec.

PerfectlyNormal commented 11 years ago

Yeah, that seems reasonable. I'll see if I can't get it converted to plain JavaScript since it's not very much of it. I'll look into it tomorrow

sobrinho commented 11 years ago

Thanks! :)

taimoor commented 11 years ago

Same issue its not working @PerfectlyNormal then why you closed it? Is there any patch or help available

PerfectlyNormal commented 11 years ago

This gem doesn't (or shouldn't) try to require CoffeeScript any longer. You are either using a very old version, or there is something else causing trouble.

What do the logs say? Any more details?

taimoor commented 11 years ago

Thanks for instant reply, I resolved this by placing this in application.rb file require 'coffee-rails'