search

PerfectlyNormal / tinymce-rails-imageupload

Image upload plugin for TinyMCE and Rails with the asset pipeline
MIT License
149 stars 153 forks source link

TinyMCE 4 compatibility #36

Closed pomartel closed 10 years ago

pomartel commented 11 years ago

Hi @PerfectlyNormal ! I was just wondering if you had any plans to make the plugin compatible with the latest TinyMCE 4 release. I haven't found any good alternatives so far that works with Rails. Let me know!

PerfectlyNormal commented 11 years ago

Hi.

I haven't paid any attention to tinyMCE 4. Had a quick look now (only have my phone), and the editor looks very nice.

I'm definitely interested in getting it working. Will probably be a few days before I can try it out though.

Sent from my iPhone

On 25 jun 2013, at 11:12 em, Pierre Olivier Martel notifications@github.com wrote:

Hi @PerfectlyNormal ! I was just wondering if you had any plans to make the plugin compatible with the latest TinyMCE 4 release. I haven't found any good alternatives so far that works with Rails. Let me know!

\ Reply to this email directly or view it on GitHub.

pomartel commented 11 years ago

Great! I played with the new TinyMCE today and it is in fact a lot nicer and faster. The UI is also much more clear. I would in fact suggest using the new layout as a base for the plugin. If you look at their example there and click on the image button, the box is simple and I guess you could reuse that for the plugin. Let me know if I can help in any ways.

pomartel commented 11 years ago

Do you have a donation link for the project? I would like to show you my support and encourage you to get the plugin working with tinyMCE 4 as soon as possible ! :)

PerfectlyNormal commented 11 years ago

Hi.

I don't have any kind of donations set up, no. Didn't really believe anyone would bother with that. I do however have an Amazon wish list 1 I keep for when christmas gets close and relatives wonder what to buy, if you really want to. It contains mostly books, and Kindle editions work very well for most of them.

However, a donation/gift/bribe isn't really necessary, and I was meaning to give it a go sometime this weekend anyways.

Best regards, Per Christian B. Viken

On Jun 29, 2013, at 4:19 PM, Pierre Olivier Martel notifications@github.com wrote:

Do you have a donation link for the project? I would like to show you my support and encourage you to get the plugin working with tinyMCE 4 as soon as possible ! :)

— Reply to this email directly or view it on GitHub.

PerfectlyNormal commented 11 years ago

Well, I have started work on this now.

I did, as I often do, decide to do a little too much at the same time, underestimating how much work it actually is both getting it to work fine with TinyMCE4 and rewriting and restructuring everything, so it's all a hopeless mess that doesn't even work right now.

I hope I'll get some free time tomorrow as well, so I can get it at least partially working, and push it up for experimentation. There's probably a ton of things that could be done to make it fit better with the architecture, and I'll study the existing plugins for ideas.

pomartel commented 11 years ago

Haha no worries! I know the feeling trying to get out of a hole you dug too deep! I'll be glad to test it out and give you my opinions once you have something working.

PerfectlyNormal commented 11 years ago

I've pushed my changes now. Things left to do:

pomartel commented 11 years ago

Great start! I'll fork it this week and see if I can at least help on the CSS part. Let me know if you make other improvements until then.

pomartel commented 11 years ago

I worked a lot on this and banged my head against the wall since there is so little documentation about the TinyMCE 4 API. I tried really hard to make the plugin work and in the end I changed my approach to use the file_browser_callback instead to develop my own file browser that integrates with the image plugin. It's working good although there are still a lot of little glitches that I can't fix without the proper hooks in the TinyMCE api.

I won't release this as a gem since there is a lot of business logic in there and it uploads directly to S3. So unfortunately I won't be able further help you because I moved away from your gem but if you have any questions regarding TinyMCE 4 API, I'm getting pretty good at it after reading a lot of the source code!

PerfectlyNormal commented 11 years ago

Hi.

Yes, the documentation could be a lot better. Wasn't easy figuring out everything, and there's still quite a bit left for this gem to be usable. I'm sorry to see you leave, as you've been a great help so far.

We use the gem at my work as well, and I'm planning to get us upgraded to TinyMCE4 in the near future, so I might be able to sneak in an hour or three fixing the gem while at work. I've had a vacation for the last few weeks now, and that's mostly why I haven't had too much motivation to get things going, and development have been going (too) slow.

Anyways, glad you got a solution that works for you.

Best regards, Per Christian B. Viken

On Jul 18, 2013, at 10:52 PM, Pierre Olivier Martel notifications@github.com wrote:

I worked a lot on this and banged my head against the wall since there is so little documentation about the TinyMCE 4 API. I tried really hard to make the plugin work and in the end I changed my approach to use the file_browser_callback instead to develop my own file browser that integrates with the image plugin. It's working good although there are still a lot of little glitches that I can't fix without the proper hooks in the TinyMCE api.

I won't release this as a gem since there is a lot of business logic in there and it uploads directly to S3. So unfortunately I won't be able further help you because I moved away from your gem but if you have any questions regarding TinyMCE 4 API, I'm getting pretty good at it after reading a lot of the source code!

— Reply to this email directly or view it on GitHub.

benjaminwood commented 11 years ago

Hey Per,

Thanks for your work on this gem! I've got a project that is currently using this with tinymce v3 and they'd like to upgrade to v4. Do you still have plans of rewriting this?

Thanks again!

PerfectlyNormal commented 11 years ago

Hmm, I replied to the mail, but doesn't look like it worked… or maybe it'll just appear in a while. Anyways,

I'm glad you like it.

Yes, I'm still planning on getting a version that's usable with v4 finished sometime soon, I've just really been swamped with work, and too tired to do much in the evenings. Our main app is using v3 a lot, and I'd really like to get us to v4, but it's not exactly a priority, since v3 works fine. I think I might have an hour or three to spare this weekend, so I'll try to do something.

Nagging usually helps, 'cause that makes me feel bad for neglecting the project ;)

PerfectlyNormal commented 11 years ago

Hi.

I'm glad you like it.

Yes, I'm still planning on getting a version that's usable with v4 finished sometime soon, I've just really been swamped with work, and too tired to do much in the evenings. Our main app is using v3 a lot, and I'd really like to get us to v4, but it's not exactly a priority, since v3 works fine. I think I might have an hour or three to spare this weekend, so I'll try to do something.

Nagging usually helps, 'cause that makes me feel bad for neglecting the project ;)

Best regards, Per Christian B. Viken

On Aug 23, 2013, at 5:27 PM, Benjamin Wood notifications@github.com wrote:

Hey Per,

Thanks for your work on this gem! I've got a project that is currently using this with tinymce v3 and they'd like to upgrade to v4. Do you still have plans of rewriting this?

Thanks again!

— Reply to this email directly or view it on GitHub.

benjaminwood commented 11 years ago

That's great, thanks for your reply and your work on this.

In the mean time, I actually managed to hack it together with a custom upload handler! :-)

nicholasmartin commented 10 years ago

My rails app is using Tinymce 4 cloud solution, and this would have been PERFECT for my project! I really hope you get this working soon Per !

Benjamin, could you share your solution in the mean time please?

benjaminwood commented 10 years ago

@lifestylenetworker I'd share if it was helpful, but our solution ended up being really custom to the app. It's not really worth recreating elsewhere. Sorry!

nicholasmartin commented 10 years ago

No problem, thanks

Nick Martin Let's ROCK!!!

This email is very short since it's crafted on my iphone.

On Thu, Sep 12, 2013 at 4:07 AM, Benjamin Wood notifications@github.com wrote:

@lifestylenetworker I'd share if it was helpful, but our solution ended up being really custom to the app. It's not really worth recreating elsewhere. Sorry!

Reply to this email directly or view it on GitHub: https://github.com/PerfectlyNormal/tinymce-rails-imageupload/issues/36#issuecomment-24271912

jalcine commented 10 years ago

Curious about what's the progress on this. I have time to help out; I'd just like to know how I can @PerfectlyNormal.

jalcine commented 10 years ago

Is that checklist still up to date?

PerfectlyNormal commented 10 years ago

Hi, and thanks for your interest.

There's not been any progress lately. We are still using TinyMCE3 a few places at work, with no hurry to upgrade to 4, and when I attempted it last, it had changed a lot, and things wasn't very cooperative, causing me to lose my motivation, and then I've just been silently ignoring my duties for a long while.

Any help would be appreciated. I think the checklist is up to date. Might be something more to do, but I don't think any of those unchecked have been taken care of yet.

PerfectlyNormal commented 10 years ago

In case anyone is still paying attention, I finally got off my ass and started fixing this again. Tracking the progress in #50