search

PerfectlyNormal / tinymce-rails-imageupload

Image upload plugin for TinyMCE and Rails with the asset pipeline
MIT License
149 stars 153 forks source link

4.0.0-beta assets problem #47

Closed mazikwyry closed 10 years ago

mazikwyry commented 10 years ago

I wanted to test 4.0.0-beta version and I have problems with assets. After lunching my app I see following problem in my JS console:

JSsc

And when I add //= require tinymce/plugins/uploadimage/langs/en.js as I used to in previous versions of gem the following error appears:

JSsc

I really like your gem and looking forward to use it with version 4 of TinyMCE.

PerfectlyNormal commented 10 years ago

As I've written in the README, and now moved directly to the top of the file, this rewrite targeting TinyMCE4 is very incomplete, and not at all usable. And due to various circumstances, I'm not really able to work on it in the near future.

Pull requests are welcome, otherwise, you (and all the others) unfortunately have to wait, or hack together something on your own

mazikwyry commented 10 years ago

I was aware that this is beta version and my intention was just to test as it is a beta version. Thanks a lot for your reply!

PerfectlyNormal commented 10 years ago

Calling it a beta is very generous. More like pre-alpha.

mvh Per Christian B. Viken

On Oct 23, 2013, at 10:26 AM, Adam Mazur notifications@github.com wrote:

I was aware that this is beta version and my intention was just to test as it is a beta version. Thanks a lot for your reply!

— Reply to this email directly or view it on GitHub.

danaki commented 10 years ago

No en.js under lang folder. Is that ok?

PerfectlyNormal commented 10 years ago

Yes, that's fine. The new way TinyMCE does translations (5b339709582e2c10657ee54106a3ff9ef2bdc5f8) is to include the english (or default) string directly in the JavaScript, and the translation uses that as a key instead of a special string.

This of course only applies to TinyMCE4. TinyMCE 3 still uses the en.js-file, and it's (still) present there.

At least, that's how I understood the documentation. It's been a while since I looked at it now…