search

PerfectlyNormal / tinymce-rails-imageupload

Image upload plugin for TinyMCE and Rails with the asset pipeline
MIT License
148 stars 153 forks source link

Image not rendering in TinyMCE on model edit action only #66

Closed rorykoehler closed 9 years ago

rorykoehler commented 9 years ago

Hi

First off thanks for an awesome gem. It works really well but I am having a problem which I can't seem to figure out. I copied your demo exactly (this one: https://github.com/PerfectlyNormal/tinymce-rails-imageupload-demo) and uploading images to a page works fine. When I look at the page show action it works fine too but when i go to the edit action it shows a broken image. It is adding '/pages/' to the beginning of the image file path so the file path is

http://localhost:3000/pages/system/images/files/000/000/001/original/image.jpeg?1419121557

when it should be:

http://localhost:3000/system/images/files/000/000/001/original/image.jpeg?1419121557

Any insights on how to fix this would be much appreciated.

Thanks

Rory

rorykoehler commented 9 years ago

Issue was with TinyMCE global settings. I had to change relative_urls to false . This was already set in your demo but I somehow missed it. If I could give a humble constructive advice (because I am clearly not at your level of expertise) it would be that users of your gem would really benefit from better install instructions in the github readme. Your demo is great but it would be much easier and faster to have a clear step by step set of instructions for dummies (like me haha) with all the settings changes you made in your demo clearly outlined. I might even do it for you.

PerfectlyNormal commented 9 years ago

Hi.

Glad you managed to get it working. I agree that the setup instructions could use some work, and a better overview of options that can be set and how they work, but I won't have time to look at it myself until after new years at the earliest.

If you are interested in writing some better instructions, send a pull request, and I'll get it merged.