search

PerfectlyNormal / tinymce-rails-imageupload

Image upload plugin for TinyMCE and Rails with the asset pipeline
MIT License
148 stars 153 forks source link

Where is the code for 4.0.17.beta.2? #86

Closed jcoyne closed 7 years ago

jcoyne commented 7 years ago

I see this released in rubygems (released 2017-04-12), but I don't see it in your github activity. Is this an authorized release?

https://rubygems.org/gems/tinymce-rails-imageupload/versions/4.0.17.beta.2

mjgiarlo commented 7 years ago

@jcoyne FWIW, here's the diff between 4.0.17.beta and 4.0.17.beta.2:

diff -r tinymce-rails-imageupload-4.0.17.beta/ tinymce-rails-imageupload-4.0.17.beta.2/
Only in tinymce-rails-imageupload-4.0.17.beta.2/app/assets/javascripts/tinymce/plugins/uploadimage/langs: pt_PT.js
diff -r tinymce-rails-imageupload-4.0.17.beta/app/assets/javascripts/tinymce/plugins/uploadimage/plugin.js tinymce-rails-imageupload-4.0.17.beta.2/app/assets/javascripts/tinymce/plugins/uploadimage/plugin.js
15c15
<           width:  500 + parseInt(editor.getLang('uploadimage.delta_width', 0), 10),
---
>           width:  520 + parseInt(editor.getLang('uploadimage.delta_width', 0), 10),
diff -r tinymce-rails-imageupload-4.0.17.beta/lib/tasks/tinymce-uploadimage-assets.rake tinymce-rails-imageupload-4.0.17.beta.2/lib/tasks/tinymce-uploadimage-assets.rake
5a6,7
>   assets = Pathname.new(File.expand_path(File.dirname(__FILE__) + "/../../vendor/assets/javascripts/tinymce"))
>   
9,14c11,16
< 
<   assets = Pathname.new(File.expand_path(File.join(File.dirname(__FILE__),
<     "../../app/assets/javascripts/tinymce/plugins/uploadimage")))
< 
<   TinyMCE::Rails::AssetInstaller.new(assets, target, manifest).install
< end
---
>   
>   installer = TinyMCE::Rails::AssetInstaller.new(assets, target, manifest)
>   installer.log_level = Logger::INFO
>   installer.strategy = config.tinymce.install
>   installer.install
> end
\ No newline at end of file
diff -r tinymce-rails-imageupload-4.0.17.beta/lib/tinymce-rails-imageupload/version.rb tinymce-rails-imageupload-4.0.17.beta.2/lib/tinymce-rails-imageupload/version.rb
4c4
<       VERSION = "4.0.17.beta"
---
>       VERSION = "4.0.17.beta.2"
mjgiarlo commented 7 years ago

Which looks like the last couple commits to master plus a version bump, which must not have been pushed or tagged.

PerfectlyNormal commented 7 years ago

Yes, I forgot to tag and push. Sorry! Should be fixed now.