search

PerfectlyNormal / tinymce-rails-imageupload

Image upload plugin for TinyMCE and Rails with the asset pipeline
MIT License
149 stars 154 forks source link

Allow updating an already inserted image #98

Open abraham opened 5 years ago

abraham commented 5 years ago

Select already inserted image to highlight toolbar button screenshot from 2018-11-16 11-33-32

Selecting toolbar button opens a window with some options

screenshot from 2018-11-16 11-33-18

Change the values and the image gets updated

screenshot from 2018-11-16 11-34-07

PerfectlyNormal commented 5 years ago

Hi

I've been waiting with this a little bit, because I'm unsure about the best way to proceed. You change the tooltip/button text, which will cause every other language to not be translated properly, as far as I know. As I don't speak most of them, I'm reluctant to attempt to update the translations myself. But at the same time, the new text describes the functionality better, so changing is probably a good idea.

I'm thinking the best way is probably just to change the translation keys for all the translations, leaving the text as-is, until the original translator or someone else decides they want it changed.

Any thoughts?

abraham commented 5 years ago

That seems like the most pragmatic approach. I'm not sure if it's possible with the TinyMCE API but another option would be keeping the current translation and than somehow switching in the edit text if an existing image is selected.