search

Perfecto-Quantum / Quantum-Starter-Kit

Get started with Quantum! Clone or download this repository to start, contains examples of tests and step definitions.
MIT License
58 stars 80 forks source link

try to mute the slf4j related messages to be showing in the console #39

Closed denghj closed 5 years ago

denghj commented 6 years ago

updated pom.xml with slf4j-simple to mute following msgs: Jun 13, 2018 4:05:47 PM org.openqa.selenium.remote.ProtocolHandshake createSession INFO: Detected dialect: OSS SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". SLF4J: Defaulting to no-operation (NOP) logger implementation SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

added simplelogger.properties to set output threhold to error to avoid the following info output to be showing in the console [TestNG] INFO com.perfectomobile.httpclient.HttpClient - Processing request Request[_requestType=DEVICE_INFO,_itemId=0117113284292401,_parameters=[ParameterValue[_name=responseFormat,_value=xml]],_stringParameters=,_encoding=] [TestNG] INFO com.perfectomobile.httpclient.HttpClient - URL = ... [TestNG] INFO com.perfectomobile.httpclient.HttpClient - Response: <?xml version="1.0" encoding="UTF-8"?> <handset modelVersion="2.21.0.0" productVersion="18.7" ... [TestNG] INFO com.perfectomobile.httpclient.HttpClient - Response values: ...

kulin24 commented 6 years ago

Hi Jack,

Thanks for this update.

I believe Jeremy has already updated this code in a Test-Kit project and we have few other things that we need to release along with this change in the next release. For now, I am not declining this pull request.

Once the Jeremy's code is checked in then will update you and then we can discuss if there is still need to add these changes.

I hope that is fine.

denghj commented 6 years ago

Sure, thanks Kulin, for taking time review the changes.