Perfexionists / perun

Lightweight Performance Control System
GNU General Public License v3.0
16 stars 14 forks source link

Fix jinja2 issue with editable build #235

Closed tfiedor closed 3 months ago

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (devel@16e9be3). Learn more about missing BASE report. Report is 9 commits behind head on devel.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #235 +/- ## ======================================== Coverage ? 99.12% ======================================== Files ? 147 Lines ? 10001 Branches ? 0 ======================================== Hits ? 9913 Misses ? 88 Partials ? 0 ``` | [Flag](https://app.codecov.io/gh/Perfexionists/perun/pull/235/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Perfexionists) | Coverage Δ | | |---|---|---| | [coverage-3.10](https://app.codecov.io/gh/Perfexionists/perun/pull/235/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Perfexionists) | `99.12% <100.00%> (?)` | | | [coverage-3.11](https://app.codecov.io/gh/Perfexionists/perun/pull/235/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Perfexionists) | `99.12% <100.00%> (?)` | | | [coverage-3.9](https://app.codecov.io/gh/Perfexionists/perun/pull/235/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Perfexionists) | `99.10% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Perfexionists#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tfiedor commented 3 months ago

Looks good. I'm wondering whether we should perhaps add at least one tox environment to test editable installs as well, so that we can somewhat reliably discover such issues early.

Good idea, done.