tfiedor
commented
3 months ago Great, adding support for importing external profiles seems like a good idea.
Maybe a quick idea for a slight improvement: would it make sense to allow the user to import the profiling configuration (i.e., cmd, workload, warmups, ...) using a single file, similarly to how the machine info is imported? I can see it being a bit mundane having to specify numerous parameters in the future if / when we decide to support more external profiles, e.g., Valgrind.
This is good idea, but I would probably make this more generic and solve it in different PR. For now it is like this after consultation with JH, who was not a fan of the additional file :)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Additional details and impacted files
```diff @@ Coverage Diff @@ ## devel #237 +/- ## ========================================== + Coverage 99.12% 99.17% +0.05% ========================================== Files 147 149 +2 Lines 10001 10111 +110 ========================================== + Hits 9913 10028 +115 + Misses 88 83 -5 ``` | [Flag](https://app.codecov.io/gh/Perfexionists/perun/pull/237/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Perfexionists) | Coverage Δ | | |---|---|---| | [coverage-3.10](https://app.codecov.io/gh/Perfexionists/perun/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Perfexionists) | `99.17% <100.00%> (+0.06%)` | :arrow_up: | | [coverage-3.11](https://app.codecov.io/gh/Perfexionists/perun/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Perfexionists) | `99.17% <100.00%> (+0.05%)` | :arrow_up: | | [coverage-3.12](https://app.codecov.io/gh/Perfexionists/perun/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Perfexionists) | `99.16% <100.00%> (+0.05%)` | :arrow_up: | | [coverage-3.9](https://app.codecov.io/gh/Perfexionists/perun/pull/237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Perfexionists) | `99.16% <100.00%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Perfexionists#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.