Perfexionists / perun

Lightweight Performance Control System
GNU General Public License v3.0
16 stars 14 forks source link

Add support for import from CSV and import dir #253

Closed JiriPavela closed 3 months ago

JiriPavela commented 3 months ago

Perun import now supports specification of imported profiles through CSV files and allows specifying the import directory.

CLI and CSV interface were extended with the ability to specify custom profile stats.

Resolves #250 Resolves #251

JiriPavela commented 3 months ago

Great, thanks for the review, I'll merge it and release it and resolve the issues in a subsequent PR. As for the issue with the fixed median: this is just a temporary solution that we agreed on with Jirka H., so that the CSV import feature is not blocked until a proper (already thoroughly discussed) solution is implemented in the future.

tfiedor commented 3 months ago

Great, thanks for the review, I'll merge it and release it and resolve the issues in a subsequent PR. As for the issue with the fixed median: this is just a temporary solution that we agreed on with Jirka H., so that the CSV import feature is not blocked until a proper (already thoroughly discussed) solution is implemented in the future.

Yeah, I know it is hotfix/workaround, I just wanted to stress that I find this important to be fixed in near future while you are in the context.