search

Perflyst / PiHoleBlocklist

PiHole and AGH Blocklists
MIT License
789 stars 116 forks source link

Invalid domains #109

Closed iteqla closed 2 years ago

iteqla commented 2 years ago

When adding the list to Gravity, the following error message appears

[i] Target: https://perflyst.github.io/PiHoleBlocklist/SmartTV-AGH.txt [✓] Status: Retrieval successful [i] Analyzed 209 domains, 204 domains invalid! Sample of invalid domains:

DandelionSprout commented 2 years ago

Do you have a link to the Gravity tool (as I've honestly never heard of it before)? It is very likely that you should use the https://raw.githubusercontent.com/Perflyst/PiHoleBlocklist/master/SmartTV.txt version of the list with that tool instead.

iteqla commented 2 years ago

Hi, the raw file you mention is not the correct one. I am referring to the Smart TV AGH list. I used the raw version, as you suggested but the problem is exactly the same. See below the latest log.

[i] Target: https://raw.githubusercontent.com/Perflyst/PiHoleBlocklist/master/SmartTV-AGH.txt [✓] Status: Retrieval successful [i] Analyzed 209 domains, 204 domains invalid! Sample of invalid domains:

DandelionSprout commented 2 years ago

I don't think you got my point. If I am correct on my guess, Gravity (whatever that is) does not support AGH lists, only raw domains lists.

iteqla commented 2 years ago

What do you mean with "Gravity (whatever that is)"? Your repository is called PiHoleBlocklists, so I am assuming the list are meant for Pihole. If they are meant for something else, I guess that closes the issue. The Gravity is the list of the domains that have been processed by Pihole's gravity (pihole -g) command.

PiHole cannot validate the domain in your list. See screenshots for further details too.

gravity 01 gravity 02 gravity 03 .

DandelionSprout commented 2 years ago

https://raw.githubusercontent.com/Perflyst/PiHoleBlocklist/master/SmartTV.txt is the Pi-hole version, the original list version, and the version used by Perflyst himself; whereas https://raw.githubusercontent.com/Perflyst/PiHoleBlocklist/master/SmartTV-AGH.txt was a somewhat late addition (Late 2019, created by me).

As awesome as it'd be to simply change repo and file names on GitHub, it's far from easy to do for adblock lists (except for Adblock Plus), since those who already use the lists would need to manually replace the old links with the new links. 😅

iteqla commented 2 years ago

Thanks for the explanation. Perhaps, if repository and files name are impossible to change, then the resolution of the problem could be adding a line to the existing description in the file itself. Something like:

! Title: Smart-TV Blocklist for AdGuard Home (by Dandelion Sprout's) ! Version: 10July2021v1 ! Description: This is a blocklist to block smart-TVs sending metadata back home, sometimes with the added benefit of blocking interface ads for apps and movie services. ! Please help to collect domains! ! It could occur that the TV fails to receive new updates, or that other apps or services no longer work. Please report such an incident. !======== This list is not compatible with Pi-Hole ========

DandelionSprout commented 2 years ago

119 aims to add such a line, but it depends on Perflyst going online again to merge it. 😅