search

Perflyst / PiHoleBlocklist

PiHole and AGH Blocklists
MIT License
789 stars 116 forks source link

Duplicated entries under Samsung, some comments won't work #123

Open LordMike opened 2 years ago

LordMike commented 2 years ago

Hey,

I looked into this to block ads on my Smart TV, and found that some lines are duplicated while others won't work.

Example. This line will likely block everything under the domain, including the time.samsun.. line:

https://github.com/Perflyst/PiHoleBlocklist/blob/fbd253636c479fe4c605407a21b1f87aaffdcab3/SmartTV.txt#L168

https://github.com/Perflyst/PiHoleBlocklist/blob/fbd253636c479fe4c605407a21b1f87aaffdcab3/SmartTV.txt#L209

It makes sense to me that if samsungcloudsolution.com is blocked, then time.samsungcloudsolution.com is also blocked. And if that's the case, then the other *.samsungcloudsolution.com entries aren't needed.

I found this as time.samsungcloudsolution.com was blocked when it shouldn't be. :)

maxfaa commented 2 years ago

Hi! If time.samsungcloudsolution.com is blocked, your TV will request "pool.ntp.org" or "worldtimeserver.com" as you can see in this screenshot: Screenshot_20220620-231728_Brave.jpg I don't say that you're wrong about the fact that blocking this domain is useless but I just remind that it doesn't break any feature.

(Btw, maybe time.samsungcloudsolution send also weird date such as telemetry (while ntp don't do that) but that's just a hypothesis...)