search

Perflyst / PiHoleBlocklist

PiHole and AGH Blocklists
MIT License
789 stars 116 forks source link

Remove too general rule #137

Closed DennisGaida closed 11 months ago

DennisGaida commented 2 years ago

This blocks all internal hostnames such as raspberrypi or myspecialserver and shouldn't be used.

I also don't understand what the actual rule is supposed to do, i.e. "connect to several garbled letter combinations". I don't think that LG TVs just connect to "goobledidock", but rather to some .com domain name?

AJCxZ0 commented 2 years ago

FWIW, this sounds a lot like Chrome's Intranet Redirect Detector.

Perflyst commented 11 months ago

It was made more specific with https://github.com/Perflyst/PiHoleBlocklist/commit/24d1fb411dbb43ace84096fbc0e7fdc0780447b0

DennisGaida commented 11 months ago

@Perflyst uhm this is still bad. /^[a-rt-z][a-z]{10,14}$/ still matches general hostnames such as raspberrypi. Probably also relevant is the commiter @DandelionSprout

Technetium1 commented 11 months ago

@Perflyst please reconsider this. The creator also tends to agree, as do I. Please see: https://github.com/Perflyst/PiHoleBlocklist/commit/24d1fb411dbb43ace84096fbc0e7fdc0780447b0#commitcomment-129547850