PerformanC / NodeLink

Performant LavaLink alternative written with Node.Js
BSD 2-Clause "Simplified" License
38 stars 23 forks source link

Send `resumed` in ready payload instead of `resume`. #12

Closed devoxin closed 8 months ago

devoxin commented 8 months ago

Changes

This changes the resume field to resumed to be inline with what Lavalink clients should expect, as per the implementation documentation at https://lavalink.dev/api/websocket.html#ready-op

Why

During my testing, my client was looking for a resumed field but was not seeing it, and throwing an error causing the websocket connection to be immediately terminated with no attempt at reconnecting. I don't believe this is the duty of clients to change as this server markets itself as being generally compatible with clients, thus the core implementation should at least match that.

Checkmarks

Additional information

N/A.

ThePedroo commented 8 months ago

Thanks for the PR. Just one thing: Could you update the commit message based on our contributing repository?

devoxin commented 8 months ago

Done.