search

PeridexisErrant / starter-pack

Automatically build a Starter Pack release from nothing
Other
121 stars 17 forks source link

Merge macOS compatibility updates from rgov/starter-pack #26

Open alexchandel opened 5 years ago

alexchandel commented 5 years ago

Merge the key macOS compatibility updates from rgov/starter-pack, while reverting the breaking TaskQueue (f004f65a8b8ce8312a7e2eed0d7fcb8d5578709c & e38f4030bd834eb8266539a800de98efdad68c34) and Unix/POSIX file mode unzipping (1958aac09c047df02b629ffe165426f5a3a3708e).

Drive-by bugfixes for newlines and for unzipping were recommitted separately (1c84665f3132e5f92d8a666276f4ffec2708e259 & 62f00582a031b1aee3f26e8671ab943a1b46a0e9).

For now, in the absence of POSIX file mode unzipping, a package builder can properly reextract PyLNP after running main.py with:

rm -rf 'build/Starter Pack Launcher (PyLNP).app'
unzip components/PyLNP_0.13b-OSX.zip -x PyLNP.json -d build  # change to latest zip
mv build/PyLNP.app 'build/Starter Pack Launcher (PyLNP).app'

Of course the final distribution zipping still fails, but that's OK since a macOS distribution will be packaged by some other means anyway (e.g. a dmg).