PeriodPals / periodpals

3 stars 1 forks source link

test/misc/fix-e2e-handle-push-perm-request : Fix end-to-end to handle push notification permission request dialog #236

Closed charliemangano closed 1 day ago

charliemangano commented 2 days ago

Fix end-to-end to handle push notification permission request dialog

This PR, contrary to usual, is asking to merge into branch test/end-to-end and not main.

Description

This PR introduces introduces a fix to issue #235, where the dialog requesting push notification permissions was making the end-to-end tests fail. More details in the description of the issue. Note: The only commit relevant for review is commit 85c39ab. For some reason, every commit pushed to main since the last update of test/end-to-end was rebased onto this branch instead of merged, I promise I didn't make 154 commits modifying 55 files. I'll be more careful with my git manipulations next time.

Changes

Added test Rule that grants the permission by default, so that the dialog is never shown.

Files

Added

None

Modified

Removed

None

Dependencies Added

None

Testing

Tests now pass. I have not modified their behavior other than was said above.

sonarcloud[bot] commented 1 day ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.9% Coverage on New Code
0.9% Duplication on New Code

See analysis details on SonarQube Cloud