Update instance check for visibility only if the plan of the instance is changed

Peripli / service-manager

Service Manager Core

Apache License 2.0

69 stars 28 forks source link

Update instance check for visibility only if the plan of the instance is changed #487

Closed DimitarPetrov closed 4 years ago

DimitarPetrov commented 4 years ago

Motivation

Currently the check assumed that if the plan is not updated it will not be presented in the request body. However CC sends the plan_id in the body even if it is not changed and remains the same. SM should make a difference between this situations because if not this makes the instance some sort of unusable.

coveralls commented 4 years ago

Coverage decreased (-0.01%) to 86.917% when pulling ddb2889da802a867f76d93ee156d38d021f87b09 on migrator-unentitled-plans into e6af60bd98bc566cea74e6432b7099b8fba5e7ac on master.