kerenlahav commented 4 years ago

Pull Request Template

Prerequisites

If there is no issue related to your pull request - open one and assign yourself to it. If you're proposing a solution to an already opened issue - simply assign yourself to it.

Motivation

The struct InstanceVisibilityMetadata can be used for other visibilities and not only instances, therefore the name should be generic

Approach

Rename the struct - the name should not contain Instances

Pull Request status

[x] Initial implementation
[x ] Refactoring
[ ] Unit tests
[ ] Integration tests

Feel free to construct the checklist with whatever items seem most reasonable for your change. You could disassemble the Implementation part to even smaller separate checklist items if you're working on something big for example. But do make the effort to provide a checklist of some sort so that the core team as well as the community can have an idea about the progress of your Pull Request.

Third-party code

If you use third party code with your contribution such as, components, libraries, or snippets make sure to mention that.

Make sure that your contribution complies with our Contribution guidelines.

Work in Progress label

For as long as development of your Pull Request is still ongoing you MUST label it with a wip label as well as prefix the name of the PR with [WIP].

For example: [WIP] Service brokers API

CLAassistant commented 4 years ago

All committers have signed the CLA.

coveralls commented 4 years ago

Coverage remained the same at 86.742% when pulling 49be2f477445aa5b2a7fc12640dffac7dac98057 on keren_VisibilityMetadata into c8467fba609f6bd1d146ee371e18736c5b1ca029 on master.

Peripli / service-manager

Rename InstanceVisibilityMetadata #498