search

Peripli / service-manager

Service Manager Core
Apache License 2.0
69 stars 28 forks source link

add validation to plan description (should not be empty) #501

Closed i041934 closed 4 years ago

i041934 commented 4 years ago

Pull Request Template

Prerequisites

https://jtrack.wdf.sap.corp/browse/NGPBUG-114921

Motivation

SM accepted catalog with empty plan's description while CC doesn't. They should be aligned. So this fix validated that a description exists

Approach

How does this change address the problem?

Pull Request status

Feel free to construct the checklist with whatever items seem most reasonable for your change. You could disassemble the Implementation part to even smaller separate checklist items if you're working on something big for example. But do make the effort to provide a checklist of some sort so that the core team as well as the community can have an idea about the progress of your Pull Request.

Third-party code

If you use third party code with your contribution such as, components, libraries, or snippets make sure to mention that.

Make sure that your contribution complies with our Contribution guidelines.

Work in Progress label

For as long as development of your Pull Request is still ongoing you MUST label it with a wip label as well as prefix the name of the PR with [WIP].

For example: [WIP] Service brokers API

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.