drorhayun commented 4 years ago

Pull Request Template

Prerequisites

If there is no issue related to your pull request - open one and assign yourself to it. If you're proposing a solution to an already opened issue - simply assign yourself to it.

Motivation

Describe the problem you're trying to solve or the feature you're proposing in addition to a link to the related issue.

Approach

How does this change address the problem?

Pull Request status

[x] Initial implementation
[ ] Refactoring
[x] Unit tests
[x] Integration tests

Feel free to construct the checklist with whatever items seem most reasonable for your change. You could disassemble the Implementation part to even smaller separate checklist items if you're working on something big for example. But do make the effort to provide a checklist of some sort so that the core team as well as the community can have an idea about the progress of your Pull Request.

Third-party code

If you use third party code with your contribution such as, components, libraries, or snippets make sure to mention that.

Make sure that your contribution complies with our Contribution guidelines.

Work in Progress label

For as long as development of your Pull Request is still ongoing you MUST label it with a wip label as well as prefix the name of the PR with [WIP].

For example: [WIP] Service brokers API

CLAassistant commented 4 years ago

All committers have signed the CLA.

coveralls commented 4 years ago

Coverage decreased (-0.3%) to 86.435% when pulling a85f1015fe41647527130630dfe8e12521300e1e on sa_termination into 004b8af50e1f731def0eca39e158b7725bee0dd1 on master.

Peripli / service-manager

Sa termination #504