search

PerkLab / MCSTrack

Multi-camera spatial tracking
MIT License
0 stars 4 forks source link

Added Scipy dependency in requirements.txt for mathematical operations in pose_solver.py #2

Closed Rampex1 closed 6 months ago

Rampex1 commented 6 months ago

Scipy.spatial.transform is used in pose_solver to return the Rotation.

vaughantnrc commented 6 months ago

Looks good, thank you for adding this. One small request - can you add back the newline to the end of requirements.txt? It's probably not a huge issue, but it can't hurt to remain compliant with the POSIX standard of what defines a file. Background: https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline

vaughantnrc commented 6 months ago

Perfect, thank you!