Detector Improvements - Githubissues

vaughantnrc commented 4 months ago

General restructuring of code for consistent style and conventions ("private" member protection)
Class names now generally indicate which "subcomponent" of Detector they belong to: Camera, Marker, Calibration
Detector configuration now has distinct sections for each of the "subcomponents"
Camera, Marker detection, and Calibration classes no longer deal with API data structures (that is instead handled in Detector)
Simpler communications between controller/GUI and Detector. Try to avoid roundtrips of data
Calibration images shall now be saved in lossless format (.png), fixes #18
Consolidate API classes into one api.py file, toward #49
User can now specify which calibration to use (the "active" one) in the GUI.
Remove unused fields from various classes

I'm not sure whether to squash or not. Although I generally tested after each commit, I'm leaning toward squashing simply because this represents a general overhaul of Detector.

keiranbarr commented 3 months ago

Looks and works good for me.

vaughantnrc commented 3 months ago

Squashed and merged.

PerkLab / MCSTrack

Detector Improvements #67