Perl-Critic / PPI

53 stars 44 forks source link

Meta files are executable in the release tarball #167

Open thaljef opened 9 years ago

thaljef commented 9 years ago

The files in git seems fine, but in the MITHALDU/PPI-1.220.tar.gz that I get from CPAN, the following files are all marked executable (0755):

Changes
LICENSE
MANIFEST
META.yml
Makefile.PL
README
README.md 

Was the release made on a Windows machine perhaps?

wchristian commented 9 years ago

Yep, thanks for the note, i'll look into that when i have some cycles. :)

adamkennedy commented 9 years ago

My release automation used to protect against that. It's possible they were fucked up in the repo and I never fixed it because of that.

Adam On Mar 24, 2015 1:40 AM, "Jeffrey Ryan Thalhammer" notifications@github.com wrote:

The files in git seems fine, but in the MITHALDU/PPI-1.220.tar.gz that I get from CPAN, the following files are all marked executable (0755):

Changes LICENSE MANIFEST META.yml Makefile.PL README README.md

Was the release made on a Windows machine perhaps?

— Reply to this email directly or view it on GitHub https://github.com/adamkennedy/PPI/issues/167.