search

Perl-Critic / PPI

53 stars 44 forks source link

remove use of Test::NoWarnings; only check for warnings in author mode. #171

Closed karenetheridge closed 7 years ago

karenetheridge commented 9 years ago

@dagolden's hitlist (https://gist.github.com/dagolden/69a93d45a34110498158) shows PPI as the second-highest consumer of Test-NoWarnings. Since warning tests for users have been considered to be harmful for a while (it prevents installation if perl core or something upstream introduces a new warning), these have been changed to run only for authors.

wchristian commented 8 years ago

I'm fine with counting tests right now. Particularly since i don't know on which Perls 0.88 runs fine. Patched this into new_tests for now.

wchristian commented 7 years ago

Thanks, this has been cherry-picked and released. :)