Perl-Critic / PPI

53 stars 44 forks source link

Allow underscores in version strings. #179

Closed contyk closed 5 years ago

contyk commented 9 years ago

This should fix gh#66, rt#75038. Although not exactly strict, it doesn't appear to break anything. Furthermore, versions like `1_.2345' are actually perfectly valid in decimal version context.

Signed-off-by: Petr Šabata contyk@redhat.com

wchristian commented 5 years ago

Thanks for the patch. I ended up dropping a number of other changes on top of this in order to make a complete implementation, and it's been released to cpan.