search

Perl-Critic / PPI

54 stars 44 forks source link

use our $VERSION rather than vars #214

Closed karenetheridge closed 7 years ago

karenetheridge commented 7 years ago

Part of the dzilification project... but merging this now will make subsequent rebases much less painful.

moregan commented 7 years ago

When we no longer support running on 5.6.x...

karenetheridge commented 7 years ago

When we no longer support running on 5.6.x...

Are you saying that our is incompatible with 5.6? Because that's not so.

wchristian commented 7 years ago

According to https://metacpan.org/pod/vars and current cpantesters matrices this does not change our backwards compat. Gonna merge it later. :)

moregan commented 7 years ago

Yes, I spoke too soon about when 'our' was introduced.

wchristian commented 7 years ago

@moregan That's fine, it happens. I'd rather see people speak up if it looks like i might mess up. :)

@karenetheridge Pushed your commit, and a handful of others that completely eradicate vars.pm, to master. Hope it helps your work!