search

Perl-Critic / PPI

54 stars 44 forks source link

Make Makefile.PL executable #219

Closed pludlamCVL closed 5 years ago

pludlamCVL commented 7 years ago

Fixes Kwalitee issue buildtool_not_executable

As part of the pull request challenge

karenetheridge commented 7 years ago

You misunderstood the kwalitee metric -- Makefile.PL is not supposed to be executable.

https://cpants.cpanauthors.org/kwalitee/buildtool_not_executable

wchristian commented 5 years ago

Thanks for the patch, but i've decided not to release this one for the time being. Marking MfPL as executable also means choosing a perl for it, and might be a security issue. Do you have further information on the Kwalitee issue buildtool_not_executable?

wchristian commented 5 years ago

On further reading of https://cpants.cpanauthors.org/kwalitee/buildtool_not_executable the issue is if the tool IS executable, which it may have been, being built on windows. Dist-Zilla now takes care of this.