Bug Fix, Exponent Operator, Cast $exponent As Number To Avoid Infinite Loop

Perl-Critic / PPI

53 stars 44 forks source link

Bug Fix, Exponent Operator, Cast $exponent As Number To Avoid Infinite Loop #230

Closed wbraswell closed 5 years ago

wbraswell commented 5 years ago

Fixes https://github.com/adamkennedy/PPI/issues/229

wbraswell commented 5 years ago

Travis confirms this bug fix actually works in all versions of Perl, most importantly 5.24 and 5.26 which were previously failing. https://travis-ci.org/wbraswell/physicsperl/builds/444291472 (Ignore false failures of "blead", that is a Travis problem.)

wbraswell commented 5 years ago

I made a 2nd commit which changed indentation from spaces-to-tabs, and changed multiply-by-one to add-to-zero. There should be no functional difference between these 2 commits.

wbraswell commented 5 years ago

@adamkennedy Can you please review and merge this pull request? Thanks!

wchristian commented 5 years ago

Thanks for the patch, i just released this to CPAN as https://metacpan.org/release/MITHALDU/PPI-1.242