search

Perl-Critic / PPI

54 stars 44 forks source link

Windows newlines in test scripts? (1.260) #238

Closed eserte closed 5 years ago

eserte commented 5 years ago

Some test files started to fail, at least on my Unix smokers:

#   Failed test 't/data/08_regression/44_vstrings: Generated dump matches stored dump'
#   at t/lib/PPI/Test/Run.pm line 70.
#     Structures begin differing at:
#          $got->[0] = 'PPI::Document'
#     $expected->[0] = 'PPI::Document
'
# Looks like you failed 1 test of 943.
t/08_regression.t ................ 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/943 subtests 
...
#   Failed test 't/data/08_regression/44_vstrings: 10 char roundtrip'
#   at t/lib/PPI/Test/Run.pm line 140.
# 
#          got: '10.10.10;
# '
#     expected: '10.10.10;
'
# 

... (etc) ...
wchristian commented 5 years ago

Thanks. Fixed in https://metacpan.org/release/MITHALDU/PPI-1.262