search

Perl-Critic / PPI

54 stars 44 forks source link

[#189] implement replace method #254

Closed reneeb closed 1 year ago

reneeb commented 3 years ago

This implements the replace method. As the docs said, the original element and the replacement need to be of the same type. IMHO it would be easy to replace any node with any other node.

oalders commented 2 years ago

Closing and re-opening to trigger CI.

oalders commented 2 years ago

@reneeb there is a test failure in t/ppi_element_replace.t

oalders commented 2 years ago

@reneeb if you could rebase and squash this once it's ready, I think it would be easier to review.

oalders commented 1 year ago

Closing this as I've got a rebased version in #274. Thanks, @reneeb!