drop IO::String prereq on perl 5.8+

wchristian commented 2 years ago

Can you add a comment in code as to why, so someone looking at it in the future doesn't have to go sleuthing when they wonder why there's this added complexity? :)

oalders commented 2 years ago

This has a couple of test failures:

Invalid separator character '+' in PerlIO layer specification + at /__w/PPI/PPI/build_dir/lib/PPI/Token/Data.pm line 68.
Unknown open() mode '<+' at /__w/PPI/PPI/build_dir/lib/PPI/Token/Data.pm line 68.
# Looks like your test exited with 22 just after 3.
t/13_data.t ...................... 
Dubious, test returned 22 (wstat 5632, 0x1600)
Failed 4/7 subtests 

#   Failed test '/__w/PPI/PPI/build_dir/lib/PPI/Token/Data.pm: All class names in static method calls'
#   at t/19_selftesting.t line 117.
#     Structures begin differing at:
#          $got = ARRAY(0x55c8aeb443b8)
#     $expected = ''

haarg commented 2 years ago

Tests are all passing now.

wchristian commented 2 years ago

Thanks for the added comments and docs. Tech-wise this looks fine and good for me, just added possible golfings as questions. If y'all don't care about 'em, go ahead imo. :)

Perl-Critic / PPI

drop IO::String prereq on perl 5.8+ #265