search

Perl-Critic / PPI

53 stars 44 forks source link

Support for Corinna keywords #299

Open davorg opened 1 month ago

davorg commented 1 month ago

I raised an issue on Perl::Metrics::Simple because it doesn't recognise that method defines a subroutine. And it turns out that the problem is PPI not supporting method (and, also, class and field).

How hard would it be to support these new keywords? I know nothing about the internals of PPI, but I'd be willing to learn if it would help get this added.

oalders commented 1 month ago

@davorg please see https://github.com/Perl-Critic/PPI/issues/273 to get an overview of the issue.

davorg commented 1 month ago

So what I'm seeing is that the PPI team was thinking about this issue even before perlclass was a thing. Which is great :-)

Feel free to ping me if you think there's anything useful I can add.

wchristian commented 1 month ago

I've been wanting to put more time into this recently, so this is a good push for me. :)

The one thing that could help would be reading over this issue to see how you feel, if any of it makes sense. Otherwise i'll end up pushing forward along that line soon. :) https://github.com/Perl-Critic/PPI/pull/280

davorg commented 1 month ago

Will do. Thanks.