Closed wchristian closed 10 years ago
And 1.219_001 is on CPAN for this.
Summary:
Details:
The bleeding edge Github version on Marpa::R2 tests all OK.
With respect to Perl-Critic/Perl-Critic#192 and Perl-Critic/Perl-Critic#390, this release does parse certain hash constructors better, but it still misses in some cases, like this: %{$a_hash_ref}
I can confirm that it fixes Perl-Critic/Perl-Critic#455
@jeffreykegler : Thanks. :)
@thaljef : Can you give me a concrete failure example, i.e. code i can run and debug? I see that %{$a_hash_ref} parses as a cast, followed by a block containing a variable, which looks correct to me. What should it be instead?
%{$a_hash_ref}
Isn't that an anonymous hash constructor instead of a block?
I can also confirm that this fixes Perl-Critic/Perl-Critic#451
This script implies strongly to me that it is indeed a block:
use strict;
use warnings;
use Data::Dumper;
my $r = { 1, 2, 3, 4 };
my %thing = %{
print qq[blah1\n];
$r;
};
print Dumper( \%thing );
__END__
blah1
$VAR1 = {
'1' => 2,
'3' => 4
};
Edit: Though amusingly Perl::Tidy gets a little confused by it.
Editedit: And thanks for the confirmations, good to know. :)
You're right, it is a block. One of my Perl::Critic test cases may be bogus. I'll investigate more tomorrow.
Neat. Enlightenment all around. :D
The title of this bug is "release 1.120" but did you mean 1.220?
Doh, you're right. Early typo. :)
@wchristian Perl-Critic is good to go with this release of PPI.
Thanks for all your effort to keep this vital project moving forward.
+1 on my PPI-using module still passing all tests.
ok here :) info. follows
$ cpanm https://cpan.metacpan.org/authors/id/M/MI/MITHALDU/PPI-1.219_001.tar.gz
--> Working on https://cpan.metacpan.org/authors/id/M/MI/MITHALDU/PPI-1.219_001.tar.gz
Fetching https://cpan.metacpan.org/authors/id/M/MI/MITHALDU/PPI-1.219_001.tar.gz ... OK
Configuring PPI-1.219_001 ... OK
Building and testing PPI-1.219_001 ... OK
Successfully installed PPI-1.219_001
1 distribution installed
$ prove -l
t/autoprereq.t .................. ok
t/scan-module.t ................. ok
t/scan_prereqs.t ................ ok
t/scanner-eval.t ................ ok
t/scanner-test_requires.t ....... ok
t/scanner-use_module.t .......... ok
t/scanner-useok.t ............... ok
t/scanner-version-assertions.t .. ok
All tests successful.
Files=8, Tests=558, 6 wallclock secs ( 0.17 usr 0.01 sys + 5.17 cusr 0.24 csys = 5.59 CPU)
Result: PASS
$ perl -v
This is perl 5, version 18, subversion 2 (v5.18.2) built for i686-linux-thread-multi
I've been travelling and unable to chip in. Thank you, @wchristian , for your continuing efforts.
@moregan Sure thing, you did plenty already. :)
If you find a little time, it would help me if you could remove some of the merged branches from your repo.
1.220 is on CPAN, now to close all the related issues. :)
mainly a not for myself