Capture variable used outside conditional (Wrong)

[thaljef]

RT Ticket: http://rt.cpan.org/Ticket/Display.html?id=24618 Requested On: Fri Jan 26 15:15:28 2007 Requested By: smueller@cpan.org

---

Hi,

If you run PAR.pm through Perl::Critic, you get:

Capture variable used outside conditional at line 555, column 18. See page 253 of PBP. Severity: 3

0555: CORE::exit($1) if ($@ =~/^_TKEXIT((\d+))/);

Now, the $1 is not used outside a conditional.

Keep up the good work!

Steffen

P.S.: I used the online-validator at perlcritic.com. I suppose it's version 1.01.

[thaljef]

RT Ticket: http://rt.cpan.org/Ticket/Display.html?id=24618 Comment On: 2007-01-27 01:46:51 Comment By: cdolan@cpan.org

---

On Fri Jan 26 18:15:30 2007, SMUELLER wrote:

If you run PAR.pm through Perl::Critic, you get:

Capture variable used outside conditional at line 555, column 18. See page 253 of PBP. Severity: 3

0555: CORE::exit($1) if ($@ =~/^_TKEXIT((\d+))/);

Now, the $1 is not used outside a conditional.

Yeah, we're not handling postfix control structures yet in the policy. I think we may have more bug reports against that one policy than any other now!

-- Chris Dolan