search

Perl-Critic / Perl-Critic

The leading static analyzer for Perl. Configurable, extensible, powerful.
http://perlcritic.com
Other
181 stars 103 forks source link

Is Perl::Critic being maintained? #517

Closed thaljef closed 11 years ago

thaljef commented 11 years ago

RT Ticket: http://rt.cpan.org/Ticket/Display.html?id=86942 Requested On: Mon Jul 15 04:07:12 2013 Requested By: TIMB@cpan.org

I see ~170 open issues, quite a few with patches, but no release in the past 12 months. I wonder if more commit bits and/or a move to a more 'social' repo like github might help.

thaljef commented 11 years ago

RT Ticket: http://rt.cpan.org/Ticket/Display.html?id=86942 Comment On: 2013-07-16 07:14:49 Comment By: jeff@imaginative-software.com

I see ~170 open issues, quite a few with patches, but no release in the past 12 months. I wonder if more commit bits and/or a move to a more 'social' repo like github might help.

Hi Tim-

I haven't been able to keep up. All my time is focused on Pinto and Stratopan right now. I can't make any promises about when the next Perl-Critic release will be.

I would love to move to GitHub. I even wrote some code to migrate all the issues from RT. And at one point, frewSchmidt wrote a script to migrate the repo (we did some weird stuff in svn). But I'm not sure it really worked and I haven't had time to debug it. I hear there are better migration tools now anyway.

You are more than welcome to take a crack at it. I can send you a dump of the whole svn repo to work from. I don't even care about the ancient history that much. As long as the recent stuff (like last 3-4 years) is there, then I'm probably happy. There is a Perl-Critic organization on GitHub. I'd be happy to make you an owner.

-Jeff

thaljef commented 11 years ago

RT Ticket: http://rt.cpan.org/Ticket/Display.html?id=86942 Comment On: 2013-07-16 10:47:03 Comment By: timb@cpan.org

There is a Perl-Critic organization on GitHub. I'd be happy to make you an owner.

I don't know how much time I'll have to contribute directly, but I might be able to do some cat herding to move things forward. So, yes, please do.

Also, are you happy for me to be a co-maint (to manage the RT queue)?

thaljef commented 11 years ago

RT Ticket: http://rt.cpan.org/Ticket/Display.html?id=86942 Comment On: 2013-07-16 10:49:23 Comment By: andremar@cpan.org

Could you put that dump of the svn repo online somewhere? I could take a crack at converting the repos there as well if you want. We have converted a lot of repos at work (including things like splitting one svn repo into many git repos).

How important are the "difficult" things, like branches, and tags? I assume tags are more important, but I don't know the state of the branches

thaljef commented 11 years ago

RT Ticket: http://rt.cpan.org/Ticket/Display.html?id=86942 Comment On: 2013-07-16 11:55:50 Comment By: jeff@imaginative-software.com

Here's the svn dump: http://perlcritic.tigris.org/files/documents/3323/49262/perlcritic.dump.tar.gz

I would definitely want the tags from the last 3 or 4 years. Branches during that time would be nice, but not mandatory. Moving to GitHub is more important. Anything older than 4 years can be discarded/ignored if it causes you any grief.

I really appreciate this. Don't bother yourself with Test-Perl-Critic and the other distros in there. I would like to move them too eventually, but they are far less important.

On Tue, Jul 16, 2013 at 3:49 AM, Andreas Marienborg via RT < bug-Perl-Critic@rt.cpan.org> wrote:

   Queue: Perl-Critic

Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=86942 >

Could you put that dump of the svn repo online somewhere? I could take a crack at converting the repos there as well if you want. We have converted a lot of repos at work (including things like splitting one svn repo into many git repos).

How important are the "difficult" things, like branches, and tags? I assume tags are more important, but I don't know the state of the branches

thaljef commented 11 years ago

RT Ticket: http://rt.cpan.org/Ticket/Display.html?id=86942 Comment On: 2013-07-16 12:03:09 Comment By: jeff@imaginative-software.com

I don't know how much time I'll have to contribute directly, but I might be able to do some cat herding to move things forward. So, yes, please do.

Done.

Also, are you happy for me to be a co-maint (to manage the RT queue)?

Will do, if I can remember how :)

Thanks so much! I saw your call to action on Twitter.

By the way: I recently discovered this: https://codeclimate.com.

I always wanted to do something like that. Especially since Perl has the best static analyzer among all the dynamic languages.

There is real money on the table there.

thaljef commented 11 years ago

RT Ticket: http://rt.cpan.org/Ticket/Display.html?id=86942 Comment On: 2013-07-16 12:08:42 Comment By: jeff@imaginative-software.com

I always wanted to do something like that. Especially since Perl has the best static analyzer among all the dynamic languages.

Oooo, I bet you could put together an NYTProf service -- Hook into git, run analysis after commits, track performance over time, pretty dashboards.

These dev-tools-as-a-service ideas are golden. Profit!

thaljef commented 11 years ago

RT Ticket: http://rt.cpan.org/Ticket/Display.html?id=86942 Comment On: 2013-07-16 12:57:27 Comment By: frew@cpan.org

For what it's worth, here is the script I ended up with: https://github.com/frioux/Git-Conversions/blob/master/perl-critic-convert

If I recall correctly the reason I stopped was mostly due to ratelimiting issues.

On Tue Jul 16 07:55:50 2013, jeff@imaginative-software.com wrote:

Here's the svn dump: http://perlcritic.tigris.org/files/documents/3323/49262/perlcritic.dump.tar.gz

I would definitely want the tags from the last 3 or 4 years. Branches during that time would be nice, but not mandatory. Moving to GitHub is more important. Anything older than 4 years can be discarded/ignored if it causes you any grief.

I really appreciate this. Don't bother yourself with Test-Perl-Critic and the other distros in there. I would like to move them too eventually, but they are far less important.

On Tue, Jul 16, 2013 at 3:49 AM, Andreas Marienborg via RT < bug-Perl-Critic@rt.cpan.org> wrote:

   Queue: Perl-Critic

Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=86942 >

Could you put that dump of the svn repo online somewhere? I could take a crack at converting the repos there as well if you want. We have converted a lot of repos at work (including things like splitting one svn repo into many git repos).

How important are the "difficult" things, like branches, and tags? I assume tags are more important, but I don't know the state of the branches

thaljef commented 11 years ago

RT Ticket: http://rt.cpan.org/Ticket/Display.html?id=86942 Comment On: 2013-07-17 05:09:09 Comment By: wyant@cpan.org

On Tue Jul 16 06:49:23 2013, ANDREMAR wrote:

Could you put that dump of the svn repo online somewhere? I could take a crack at converting the repos there as well if you want. We have converted a lot of repos at work (including things like splitting one svn repo into many git repos).

How important are the "difficult" things, like branches, and tags? I assume tags are more important, but I don't know the state of the branches

Branches I know myself to have committed:

Unfortunately there are a lot of other things going on in my life right now, not all of them things I would wish for. What time I have had for Perl has been largely consumed by Astro::SpaceTrack (U. S. Strat Com changed the API, and the old one retired today). I know excuses are not what Perl::Critic needs right now. I will do what I can.

Tom

thaljef commented 11 years ago

RT Ticket: http://rt.cpan.org/Ticket/Display.html?id=86942 Comment On: 2013-07-17 09:32:08 Comment By: timb@cpan.org

On Wed Jul 17 06:09:09 2013, WYANT wrote:

[...useful history...]

I will do what I can.

Understood. Thanks Tom.

thaljef commented 11 years ago

RT Ticket: http://rt.cpan.org/Ticket/Display.html?id=86942 Comment On: 2013-07-17 13:17:36 Comment By: frew@cpan.org

Ok, I've let my exporter run overnight and now I have an ok export. I cannot push it to github because at some point a bunch of gigantic java files got added directly to the repo.

I'm going to filter out the buildserver directory (if anyone wants it they can get it from subversion :) as well as update some of the tags that have been created since I started my conversion a couple years ago. Expect an update later today. Also, one thing I'll go ahead and do is add a bunch of comments to the conversion so you guys can look it over and check what I did.

thaljef commented 11 years ago

RT Ticket: http://rt.cpan.org/Ticket/Display.html?id=86942 Comment On: 2013-07-18 13:48:27 Comment By: timb@cpan.org

On Wed Jul 17 14:17:36 2013, frew wrote:

Ok, I've let my exporter run overnight and now I have an ok export. [...] Expect an update later today.

Thanks great!

(Also, one thing I'll go ahead and do is add a bunch of comments to the conversion so you guys can look it over and check what I did.)

Thanks. Also, please post further updates to the migration ticket https://rt.cpan.org/Ticket/Display.html?id=86973 rather than this one. Thanks again frew.

thaljef commented 11 years ago

RT Ticket: http://rt.cpan.org/Ticket/Display.html?id=86942 Comment On: 2013-07-22 11:29:24 Comment By: dolmen@cpan.org

Le 2013-07-16 12:47:03, TIMB a ?crit?:

Also, are you happy for me to be a co-maint (to manage the RT queue)?

You don't have to be co-maint to manage the RT queue. Just add yourself as a requester to each ticket and you get full rights to modify the ticket.

Olivier Mengu? - http://perlresume.org/DOLMEN

thaljef commented 11 years ago

RT Ticket: http://rt.cpan.org/Ticket/Display.html?id=86942 Comment On: 2013-07-22 11:35:00 Comment By: dolmen@cpan.org

Le 2013-07-15 13:07:12, TIMB a ?crit?:

I see ~170 open issues, quite a few with patches, but no release in

I'll resubmit my own patches (RT#75300, RT#75329) as pull requests as soon as the code is on Github. Or directly if I get a commit bit...

Olivier Mengu? - http://perlresume.org/DOLMEN

thaljef commented 11 years ago

I'll resubmit my own patches (RT#75300, RT#75329) as pull requests as soon as the code is on Github. Or directly if I get a commit bit...

All the code and RT tickets have been migrated to GitHub.

@dolmen you now have a commit bit. Fire at will.