Instantiate Perl::Critic only once

[petdance]

Slick. I like it.

[holcapek]

I squashed couple of commits into one, since one without the others wouldn't make sense. The change is pretty small, anyway.

[petdance]

I'd like to get this merged, but the test fails under Travis. Can you please look into it?

[petdance]

And, are we sure there's no ill effects of reusing the singleton?

[holcapek]

@petdance As for the test failing under Travis: it actually fails also on my local computer, but unfortunately, I didn't take it seriously. Moreover, it fails also with no changes to the upstream, as you can see at PR https://github.com/Perl-Critic/Test-Perl-Critic/pull/13

I don't know what's wrong, I'll keep you posted if I find the cause.

[petdance]

Can I close this and let you create a new PR when you've got it going?

[holcapek]

No problem, let's close it for now.

[holcapek]

Hi @petdance , any chance this could be merged in provided the tests has been fixed previously? Thanks!

[pali]

@petdance: can you look at this change?

[petdance]

Done. It's in the just-pushed-to-CPAN 1.04. Thanks for the nudge.

[holcapek]

@petdance Thanks!