search

Perl-Critic / Test-Perl-Critic

Run Perl::Critic as a unit test
http://perlcritic.com
Other
9 stars 7 forks source link

Apply fix from bug #9 #12

Closed colinnewell closed 6 years ago

colinnewell commented 6 years ago

This is simply the application of the patch from the bug report.

holcapek commented 6 years ago

@petdance With this change applied to #11 , ./Build authortest do pass and Travis is happy. I'd also be happy seeing this PR being merged. @colinnewell Thanks!

petdance commented 6 years ago

OK, I'll see what I can do tomorrow.

holcapek commented 6 years ago

@petdance Hi, is there a chance for this being merged anytime soon? I would like to re-open #11 with this change applied. Thanks! @colinnewell Could you please enable Travis CI for this PR in order to make it visible the test no longer fails? Thanks!

colinnewell commented 6 years ago

@holcapek I don't understand? I can see a green tick by the commit and the Travis results there. The travis wasn't run by the forked repo, but it has since the pull request has been made.

holcapek commented 6 years ago

@colinnewell I am terribly sorry. I failed to click on Show all checks. I am just used to seeing it without doing anything.