Send Inline 'auto_headers' when used 'with' Alien::OpenMP.

Perl-OpenMP / p5-Alien-OpenMP

Portable buildopt interface to OpenMP enabled compiler flags and other things.

1 stars 4 forks source link

Send Inline 'auto_headers' when used 'with' Alien::OpenMP. #18

Closed oodler577 closed 2 years ago

oodler577 commented 2 years ago

I'll leave this up for a couple of days or until someone approves it. Please let me know if there are any things you think might be problematic.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1460149481

3 of 5 (60.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-2.7%) to 83.673%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
lib/Alien/OpenMP/configure.pm	0	2	0.0%
<!--	Total:	3	5	60.0%	-->

Totals
Change from base Build 1406600521:	-2.7%
Covered Lines:	41
Relevant Lines:	49

💛 - Coveralls

mohawk2 commented 2 years ago

Why is this removing the non-linux CI config?

oodler577 commented 2 years ago

Why is this removing the non-linux CI config?

Because I want to get the change in and not spend an inordinant amount of time worrying about CI; paricularly on a platform with a low chance of relevance, I'm happy to hack on the CI after tho.

mohawk2 commented 2 years ago

Why is this removing the non-linux CI config?

Because I want to get the change in and not spend an inordinant amount of time worrying about CI; paricularly on a platform with a low chance of relevance, I'm happy to hack on the CI after tho.

Only just saw this. @zmughal has fixed up the problems, and I have added them on this branch instead of the now-unneeded CI removal. I believe he would be an excellent additional member of this GH org, by the way.

mohawk2 commented 2 years ago

@zmughal [...] I believe he would be an excellent additional member of this GH org, by the way.

I confused myself about the above - he is already a member, but I gather doesn't have push access to this repo for some reason.

oodler577 commented 2 years ago

@zmughal [...] I believe he would be an excellent additional member of this GH org, by the way.

I confused myself about the above - he is already a member, but I gather doesn't have push access to this repo for some reason.

He and @kiwiroy have been added with write perms. Thanks for pointing that out.

oodler577 commented 2 years ago

Thanks @zmughal, @kiwiroy, @mohawk2 - this was a real team effort! Unless someone gets to it before me, I'll get this merge in and will make a release sometime this evening.

mohawk2 commented 2 years ago

I have released this as 0.003006.