search

Perl-Toolchain-Gang / CPAN-DistnameInfo

Extract information from a CPAN distribution name
http://search.cpan.org/dist/CPAN-DistnameInfo/
9 stars 9 forks source link

Fix test failure #4

Open jmaslak opened 8 years ago

jmaslak commented 8 years ago

The git repo code would not pass make test. I've fixed that.

The code was stripping -TRIAL (but not -TRIAL3) from the version number - I removed the stripping action, thus allowing it to pass path.t. However, that made it fail ext.t instead (which expected -TRIAL.* to be removed). Looking at the version on CPAN, -TRIAL was present there and not stripped, and the tests that failed after the change back were not present in ext.t. I also think that the -TRIAL indicator could be significant as part of the version, so I think this is the right fix.

However, if it's not, and it should be stripped, let me know and I'll be glad to submit a PR with that in mind instead.

FYI this submission is part of the CPAN Pull Request Challenge - I was assigned your module for August.

jmaslak commented 8 years ago

Note that my change does disagree with PR #2 - they felt that -TRIAL should be removed (and likely that is where this bug got introduced for the test failure). I have a different patch that is compatible with PR#2 but fixes the test failures if that's preferred.