Perl-Toolchain-Gang / ExtUtils-MakeMaker

Perl module to make Makefiles and build modules (what backs Makefile.PL)
https://metacpan.org/release/ExtUtils-MakeMaker
64 stars 76 forks source link

fix PERL_CORE warnings from ExtUtils::CBuilder #373

Closed haarg closed 3 years ago

haarg commented 3 years ago

ExtUtils::CBuilder is used to detect if we have a compiler available. It has some oddities and doesn't work well in parallel. We run it from a temporary directory to avoid that. When doing a core build, and in a temp directory, CBuilder sees PERL_CORE but can't find the perl source and complains.

If we're running perl core tests, there's no real need to check for a compiler. We can just assume one is available. Avoid CBuilder's mess and just return true from our compiler check if running with PERL_CORE.

Fixes #372

Leont commented 3 years ago

Looks sensible to me