Perl-Toolchain-Gang / ExtUtils-MakeMaker

Perl module to make Makefiles and build modules (what backs Makefile.PL)
https://metacpan.org/release/ExtUtils-MakeMaker
64 stars 77 forks source link

fix loss of $Config{ccflags} on darwin #379

Closed tonycoz closed 3 years ago

tonycoz commented 3 years ago

This skips some of the cleanup that EU::MM_Unix::cflags does, it might be better to have an extra_cflags()* method to add the -Wno-error=... instead of using cflags as the original commit did, but this Works For Me.

*or whatever name

haarg commented 3 years ago

This doesn't seem like the correct solution. I think the problem is the order. Other OS modules that override cflags call SUPER::cflags first before making their modifications.

tonycoz commented 3 years ago

@haarg 's #380 is better, so closing this one.