search

Perl-Toolchain-Gang / ExtUtils-MakeMaker

Perl module to make Makefiles and build modules (what backs Makefile.PL)
https://metacpan.org/release/ExtUtils-MakeMaker
64 stars 76 forks source link

Retrofit haikuports patchset to support haiku as a separated platform from BeOS #396

Closed thibaultduponchelle closed 3 years ago

thibaultduponchelle commented 3 years ago

Hello 😀

I propose this change to retrofit the portions of haikuports patch related to EUMM. See haikuports perl patchset

Haiku has now some differences versus BeOS (filesystem hierarchy conventions...) that justifies this new "platform variant".

I tested it with perl 5.34.0 but I'm not a haiku expert and the code is not mine but from @olta

@bingos How do you feel about this change ?

Leont commented 3 years ago

This should also adapt t/MM_BeOS.t

thibaultduponchelle commented 3 years ago

I removed a portion of the patch since it should be fixed at perl5 compilation level: if you use -Dprefix... set also siteprefix and you're all good.

I changed the require to use.

I kept the first function to use vendor on env var, it seems intended to haiku packagers (can be emulated easily for one package with perl Makefile.PL INSTALLDIRS=vendor) and I also kept the LD_RUN_PATH patch that seems the most interesting (even if I don't understand it 100%).

Concerning the BeOS support, I'm asking a status to some people from Haiku community to have a first idea, but maybe we can keep this part out of this PR?

thibaultduponchelle commented 3 years ago

Having continued to work on this topic, I'm not 100% convinced about this change, so I will close it for now, waiting to know what is really needed and what is not.

(Thank you for the code review)