search

Perl-Toolchain-Gang / ExtUtils-MakeMaker

Perl module to make Makefiles and build modules (what backs Makefile.PL)
https://metacpan.org/release/ExtUtils-MakeMaker
64 stars 77 forks source link

Add -rpath when compiling XS modules on macOS #403

Closed hakonhagland closed 2 years ago

hakonhagland commented 3 years ago

This change fixes issue #402 on my machine.

Leont commented 3 years ago

Can you please change the commit title to something that actually describe what it does?

hakonhagland commented 3 years ago

@Leont I have updated the title to something more descriptive.

haarg commented 3 years ago

The important thing to fix is the subject of the actual commit, not the title of the PR.

hakonhagland commented 3 years ago

@haarg I have update the commit message with the same title

mohawk2 commented 3 years ago

@hakonhagland Could you add a test that breaks on MacOS without this change? That way we can permanently capture the benefit.

hakonhagland commented 3 years ago

@mohawk2 I have added a test case, see the new commits.

mohawk2 commented 3 years ago

@mohawk2 I have added a test case, see the new commits.

Looks good. I've enabled the CI to run.