search

Perl-Toolchain-Gang / ExtUtils-MakeMaker

Perl module to make Makefiles and build modules (what backs Makefile.PL)
https://metacpan.org/release/ExtUtils-MakeMaker
64 stars 77 forks source link

-Wl,-rpath not supported on Mac OS X 10.4 #410

Open evanmiller opened 2 years ago

evanmiller commented 2 years ago

403 has broken Makefile generation on Mac OS X 10.4 and earlier, whose linkers do not support -rpath. A proposed patch can be found here (taken from https://github.com/macports/macports-ports/pull/13529):

https://raw.githubusercontent.com/macports/macports-ports/8ea194cdc747dfb772b6f968d8e561da80440e58/perl/p5-extutils-makemaker/files/patch-extutils-makemaker-rpath.diff

hakonhagland commented 2 years ago

@evanmiller Thanks for the report and patch!

@Maintainers: I can create a pull request from the patch if needed? What is common practice with patches?

Leont commented 2 years ago

Yeah, a pull request is appreciated.

hakonhagland commented 2 years ago

@Leont Ok, I have added a PR, see #412

sevan commented 1 year ago

The test suite also needs to be handled. I have a smoke test on Tiger in flight at the moment and I see

[2023-04-18 02:53:17-0400]     ../cpan/ExtUtils-MakeMaker/t/04-xs-rpath-darwin.t...........FAILED
[2023-04-18 02:53:17-0400]         Non-zero exit status: 255
[2023-04-18 02:53:17-0400]     ../cpan/ExtUtils-MakeMaker/t/04-xs-rpath-darwin.t...........FAILED
[2023-04-18 02:53:17-0400]         Bad plan.  You planned 1 tests but ran 0.